fix(rust): Ensure eprintln! is only called within debug/verbose context
#15100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrumiller
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15100 +/- ##
==========================================
- Coverage 81.07% 81.06% -0.02%
==========================================
Files 1342 1342
Lines 173942 173948 +6
Branches 2459 2459
==========================================
- Hits 141021 141008 -13
- Misses 32455 32474 +19
Partials 466 466 ☔ View full report in Codecov by Sentry. |
|
Thank you @mcrumiller! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15099.
Also found one more
eprintlnthat wasn't properly wrapped.Not worth adding a unit test, but OP's example no longer prints the result to stderr.